feat: provide support for groupby #2175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11081499018Details
💛 - Coveralls |
aaqilniz
force-pushed
the
feat/support-groupby
branch
from
53a31da
to
352b803
Compare
aaqilniz
force-pushed
the
feat/support-groupby
branch
from
fca6247
to
9eb2439
Compare
This was referenced Aug 16, 2024
samarpanB
reviewed
Sep 1, 2024
| nodes = nodes.slice(skip, skip + limit); | ||
| if (filter.groupBy) { |
There was a problem hiding this comment.
this will require support for connector too
There was a problem hiding this comment.
Yes. And it's implemented here.
samarpanB
reviewed
Sep 1, 2024
| @@ -272,6 +272,28 @@ describe('crud-with-options', function() { | |||
| User.find({limit: 3}); | |||
| }); | |||
|
|
|||
| it('should allow filter with groupBy, count, max, min, sum & avg', function(done) { | |||
There was a problem hiding this comment.
can you add test cases for when there are other filter queries too and limit and offset is also provided ? Basically to confirm whether this feature works with other features together or not. And whether it has any impact there.
There was a problem hiding this comment.
Hi, @samarpanB. I have added one more test to verify the change with existing filters.
aaqilniz
force-pushed
the
feat/support-groupby
branch
7 times, most recently
from
82da092
to
a4872f5
Compare
Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>
aaqilniz
force-pushed
the
feat/support-groupby
branch
from
a4872f5
to
757f670
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the loopback-datasource-juggler to add min(), max(), count(), avg() & sum() in the result.
Related PRs:
Checklist
npm testpasses on your machine