Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename johnsoncodehk.volar extension #908

Merged

Conversation

movermeyer
Copy link
Contributor

What are you trying to accomplish?

In chasing down the Vue issues plaguing the build, I looked into this error message:

Installing extensions...
Extension 'johnsoncodehk.volar' not found.
Make sure you use the full extension ID, including the publisher, e.g.: ms-dotnettools.csharp
Failed Installing Extensions: johnsoncodehk.volar

The extension has been renamed to vue.volar, as seen by the redirect in the Marketplace.

What approach did you choose and why?

Simple rename.

What should reviewers focus on?

To be candid, I'm not sure whether/why this extension is needed at all.

The impact of these changes

Less cluttered error log.

Testing

yarn test:fixture

@kibertoad kibertoad merged commit f04556a into lokalise:main Apr 25, 2023
huacnlee pushed a commit to huacnlee/i18n-ally that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants