Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid overriding paths and destroy path on remove #4560

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

logaretm
Copy link
Owner

@logaretm logaretm commented Nov 23, 2023

Closes #4476

Closes #4557

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f24dd1) 97.33% compared to head (2aef89e) 97.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4560   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files          86       86           
  Lines        6780     6781    +1     
  Branches     1253     1256    +3     
=======================================
+ Hits         6599     6600    +1     
  Misses        181      181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@logaretm logaretm marked this pull request as ready for review November 23, 2023 22:19
@logaretm logaretm merged commit f688896 into main Nov 23, 2023
7 checks passed
@logaretm logaretm deleted the fix/array-paths-conflicts branch November 23, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant