Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement joi schema support #4463

Merged
merged 12 commits into from
Sep 14, 2023

Conversation

lallenfrancisl
Copy link
Contributor

πŸ”Ž Overview

This PR implements support for using joi schemas for validation

βœ” Issues affected
closes #3964

@lallenfrancisl
Copy link
Contributor Author

Also could you point me to where I can update the documentation on the website ?

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #4463 (589b869) into main (c372718) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4463   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files          79       79           
  Lines        6226     6226           
  Branches     1179     1179           
=======================================
  Hits         6111     6111           
  Misses        115      115           

πŸ“£ We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lallenfrancisl
Copy link
Contributor Author

Rebased because I committed from a wrong email address

@lallenfrancisl
Copy link
Contributor Author

@logaretm Could you take a look and suggest changes ?

Copy link
Owner

@logaretm logaretm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, looks great and I will publish it after merge.

@logaretm logaretm merged commit 0983d54 into logaretm:main Sep 14, 2023
8 checks passed
@lallenfrancisl lallenfrancisl deleted the feat/joi-support branch September 15, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for joi as validation schema
2 participants