Upgrade to rely on package.patterns
#193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any change to merge it? |
|
Will merge and cut a new major release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for
package.includeis deprecated on Serverless Framework side and is scheduled to be removed with v3This PR ensures that plugin internally relies on
package.patternsas first choice.I've additionally added
serverlessas peer dependency and indicated minimal version which supportspackage.patternsI believe this should be considered as breaking change (as will stop working with Framework versions below 2.32.0) and should be released as a new major
Additionally I've fixed promises handling in tests (they weren't returned which in some cases resulted in improper communication of failures)