Add <NAME> arg to help output #1904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
johannesfrey
reviewed
Jul 4, 2024
| @@ -33,7 +33,7 @@ vcluster platform add vcluster my-vcluster --namespace vcluster-my-vcluster --pr | |||
| ` | |||
|
|
|||
| addCmd := &cobra.Command{ | |||
| Use: "vcluster", | |||
| Use: "vcluster VCLUSTER_NAME", | |||
There was a problem hiding this comment.
We could also use this util func that we already use in some places (probably not consistent over the whole code base): https://github.com/loft-sh/vcluster/blob/main/cmd/vclusterctl/cmd/create.go#L35
| @@ -33,7 +33,7 @@ vcluster platform add vcluster my-vcluster --namespace vcluster-my-vcluster --pr | |||
| ` | |||
|
|
|||
| addCmd := &cobra.Command{ | |||
| Use: "vcluster", | |||
| Use: "vcluster VCLUSTER_NAME", | |||
| Short: "Adds an existing vCluster to the vCluster platform", | |||
| Long: description, | |||
| Args: cobra.ExactArgs(1), | |||
There was a problem hiding this comment.
| @@ -50,7 +50,7 @@ func NewClusterCmd(globalFlags *flags.GlobalFlags) *cobra.Command { | |||
| } | |||
|
|
|||
| c := &cobra.Command{ | |||
| Use: "cluster", | |||
| Use: "cluster CLUSTER_NAME", | |||
There was a problem hiding this comment.
If we go the util route we might want to add a Cluster entry there as well!?
FabianKramm
requested changes
Jul 4, 2024
|
Can you elaborate @FabianKramm ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #
ENG-4070