No agent found with Sleep Mode configured: vCluster logs, CLI output #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igured without an agent installed
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
rmweir
previously requested changes
Jul 3, 2024
Comment on lines
+377
to
+384
| podList, err := cmd.kubeClient.CoreV1().Pods("").List(ctx, metav1.ListOptions{ | ||
| LabelSelector: "app=loft", | ||
| }) | ||
| if err != nil && !kerrors.IsNotFound(err) { | ||
| return false, err | ||
| } | ||
|
|
||
| return len(podList.Items) > 0, nil |
There was a problem hiding this comment.
Since people can deploy loft in any namespace, I'm not sure if this would be a good idea
FabianKramm
approved these changes
Jul 4, 2024
FabianKramm
dismissed
rmweir’s stale review
People can deploy with arbitrary namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-3890