Both succeeded and failed requests are counted in total number of requests #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #939 +/- ##
==========================================
+ Coverage 66.55% 66.57% +0.02%
==========================================
Files 14 14
Lines 1438 1439 +1
Branches 226 226
==========================================
+ Hits 957 958 +1
Misses 430 430
Partials 51 51
Continue to review full report at Codecov.
|
raiyankamal
changed the title
cgoldberg
approved these changes
Jan 19, 2019
|
thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on @cgoldberg 's comment in #884, the logic for counting requests is modified so that # requests include both failed and succeeded requests.
This PR superseeds #884