Failed requests are counted in total number of requests (#939)

locustio · Jan 19, 2019 · 0846b3f · 0846b3f
1 parent e3a74db
commit 0846b3f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/locust/stats.py b/locust/stats.py
@@ -558,6 +558,7 @@ def on_request_success(request_type, name, response_time, response_length, **kwa
     global_stats.log_request(request_type, name, response_time, response_length)
 
 def on_request_failure(request_type, name, response_time, exception, **kwargs):
+    global_stats.log_request(request_type, name, response_time, 0)
     global_stats.log_error(request_type, name, exception)
 
 def on_report_to_master(client_id, data):

diff --git a/locust/test/test_stats.py b/locust/test/test_stats.py
@@ -311,7 +311,7 @@ class MyLocust(HttpLocust):
         response = locust.client.get("/", timeout=0.1)
         self.assertEqual(response.status_code, 0)
         self.assertEqual(1, global_stats.get("/", "GET").num_failures)
-        self.assertEqual(0, global_stats.get("/", "GET").num_requests)
+        self.assertEqual(1, global_stats.get("/", "GET").num_requests)
 
 
 class MyTaskSet(TaskSet):