Improve TopologyPreservingSimplifier to prevent edge-disjoint line collapse #925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves
TopologyPreservingSimplifier
to avoid collapsing edge-disjoint lines together when tolerance is large.The old code would not maintain the topology of sets of edges-disjoint lines which were closer than the simplification tolerance. In the following example a set of edge-disjoint lines collapse together with a tolerance of 150:
With the improved code the lines are simplified as much as possible while being kept edge-disjoint:
Note: there is a still an issue which allows fully-disjoint edges to "cross over" each other.