Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OverlayNGRobust self-snapping to prevent heterogeneous results #618

Merged
merged 4 commits into from
Oct 23, 2020

Conversation

dr-jts
Copy link
Contributor

@dr-jts dr-jts commented Oct 23, 2020

Fixes OverlayNGRobust self-snapping to prevent heterogeneous results causing failure in subsequent overlay operations.

Issue first identified during integration testing of OverlayNG in R-sf (seen r-spatial/sf#794).

Signed-off-by: Martin Davis <mtnclimb@gmail.com>
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
Test case

Signed-off-by: Martin Davis <mtnclimb@gmail.com>
Signed-off-by: Martin Davis <mtnclimb@gmail.com>
@dr-jts dr-jts merged commit 6ef89b0 into locationtech:master Oct 23, 2020
@dr-jts dr-jts deleted the fix-overlay-robust-snapping branch October 23, 2020 23:03
@strk
Copy link

strk commented Oct 26, 2020

GEOS port will be tracked by https://trac.osgeo.org/geos/ticket/1062

strk added a commit to libgeos/geos that referenced this pull request Oct 26, 2020
 * Add explicit check for hetero overlay input
 * Fix to prevent hetero results from self-snapping
 * Include test case

Closes #1062
This is a port of locationtech/jts#618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants