Fixed MinimumBoundingCircle.getMaximumDiameter() to handle case where extremalPts[2]-[0] is longest #533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
It seemed that
MinimumBoundingCircle.getMaximumDiameter()
returns farther pair only amongextremalPts[0]-[1]
andextremalPts[1]-[2]
ifextremalPts.length == 3
.I thought this can cause unexpected result when
extremalPts
consists of 3 points forming acute triangle, and the longest segment isextremalPts[2]-[0]
.(Please take a look at the case added at
MinimumBoundingCircleTest.testMinDiameterPolygon()
.)So I'm suggesting a change for
farthestPoints()
to handle this case as well by checking all three segment length.Maybe I have misunderstood the purpose of
getMaximumDiameter()
, but if I have understood the method description comments correctly, this fix could be helpful.Thank you :)