Make Geometry.reverse() consistent

[FObermaier]

• Add protected reverseInternal function to Geometry,
  implement in Point, LineString, LinearRing, Polygon and
  GeometryCollection
• Remove abstract from Geometry.reverse function,
  implementation calls reverseInternal and copies
  Envelope and SRID values
• To avoid breaking change make Geometry.reverse overrides
  return super.reverse()
• Add unit test

Note:
The reversal of items in MultiLineString has been removed.

closes to #305

Signed-off-by: Felix Obermaier felix.obermaier@netcologne.de

[dr-jts]

Thanks, code looks good.

It's unfortunate that the commits are cluttered up with formatting changes (mainly whitespace removal). Not sure if it's possible to avoid this?

[FObermaier]

IntelliJ did that. I must admit I like it. See #397.

[dr-jts]

Yes, I like consistent formatting as well (have been working with Go lately, and it's opinionated formatting works very well).

It's just not ideal to mix formatting changes and code changes, since the code changes get swamped by all the trivial format changes.

[FObermaier]

For the review you might want to try

I'm not going to re-add trailing white-space to get this accepted. Take what you like.

[dr-jts]

Oh, great, didn't know that was available. That helps with reviewing for sure.

[dr-jts]

@FObermaier the deprecations on the subclass reverse methods are causing problems, since they shadow the Geometry.reverse method. Isn't it sufficient to just remove the subclass methods? Or does that break something?

[FObermaier]

I'm no java expert. I wanted to avoid introducing a breaking change. I was not aware that this causes other issues.

[dr-jts]

@FObermaier understood. This is a trickier design situation than it first appears.