Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to update junit version #607

Closed
FObermaier opened this issue Oct 1, 2020 · 7 comments
Closed

Request to update junit version #607

FObermaier opened this issue Oct 1, 2020 · 7 comments

Comments

@FObermaier
Copy link
Contributor

I tend to use IntelliJ IDEA Community as java editor, especially when working with this project.
This editor does not play with junit v3.7 and requires at least v3.8 so I kindly request to update junit to this version.

Thanks.

@jnh5y
Copy link
Contributor

jnh5y commented Oct 1, 2020

Looks like 3.8.2 is the latest in the 3.x line.

Does anyone happen to know if Junit 4.x would be compatible without code changes?

@mprins
Copy link
Contributor

mprins commented Oct 2, 2020

@FObermaier
Copy link
Contributor Author

FObermaier commented Oct 5, 2020

I updated to v4.13 and rebuild the solution. It built without any severe problems, there are some deprecation warnings about using junit.framework.Assert class.

I don't know if the list is complete but here are some classes:

  • KMLReaderTest
  • BufferValidator
  • GeometryOperationValidator

See: #609

@dr-jts
Copy link
Contributor

dr-jts commented Oct 5, 2020

I there are some deprecation warnings about using junit.framework.Assert class.

It would be nice to fix the deprecations. Any idea what a fix would be?

@mprins
Copy link
Contributor

mprins commented Oct 5, 2020

I think the Assert class now lives in org.junit.Assert https://junit.org/junit4/javadoc/4.13/org/junit/Assert.html

@jnh5y
Copy link
Contributor

jnh5y commented Oct 5, 2020

@mprins Thanks! @FObermaier I tried switching the imports and it seemed to work. Here's a quick commit that does it: jnh5y@ee9975e

@FObermaier FObermaier changed the title Request to update junit to version v3.8 Request to update junit version Oct 6, 2020
dr-jts pushed a commit that referenced this issue Oct 6, 2020
* Update junit to v4.13
* Fix deprecation warnings for junit.framework.Assert

Assert now lives in `org.junit` namespace

Signed-off-by: Felix Obermaier <felix.obermaier@netcologne.de>
@FObermaier
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants