correct typo in Designer Sweatpants regexp #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rinn
approved these changes
Apr 11, 2024
* make sweatpants less noisy * use bar as delimiter instead * Update packages/excavator-projects/projects/designerSweatpants.ts * Update packages/excavator-projects/projects/designerSweatpants.ts --------- Co-authored-by: Joe Kirchoff <Kirchoff.Joseph.P@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
* correct typo in Designer Sweatpants regexp * make sweatpants less noisy (#72) * make sweatpants less noisy * use bar as delimiter instead * Update packages/excavator-projects/projects/designerSweatpants.ts * Update packages/excavator-projects/projects/designerSweatpants.ts --------- Co-authored-by: Joe Kirchoff <Kirchoff.Joseph.P@gmail.com> --------- Co-authored-by: Joe Kirchoff <Kirchoff.Joseph.P@gmail.com>
gausie
reviewed
Apr 12, 2024
| if (!sweat) return null; | ||
|
|
||
| const location = toNormalisedString(myLocation()); | ||
| const reportedLocations = getProperty("excavatorSweatpantsLocations").split( |
There was a problem hiding this comment.
Excavator never sets prefs, this is unfortunate
There was a problem hiding this comment.
There’s no problem with being noisy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.