pbpm_fmcpico1M/machine_pkg.vhd: adjust PBPM rates #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would add some comments to the source code explaining that these rates are not synchronised to the timing system and that the TbT rate is way off (500 KHz vs 578 KHz). |
Adjust PBPM rates so they're the closest possible to EBPM rates. Note that PBMs aren't synchronized to the Timing system, so no sampling frequency/phase relation should be assumed between them and EBPMs.
guilhermerc
force-pushed
the
fix-pbpm-rates
branch
from
9a43e1b
to
0a7b9ca
Compare
guilhermerc
force-pushed
the
fix-pbpm-rates
branch
from
0a7b9ca
to
4838505
Compare
|
👍 |
augustofg
approved these changes
Jun 21, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust PBPM rates so they're the closest possible to EBPM rates.
Note that PBMs aren't synchronized to the Timing system, so no sampling frequency/phase relation should be assumed between them and EBPMs.