Enable support for Pycharm using the built-in web server #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmichelin
reviewed
Mar 6, 2021
| @@ -17,6 +17,7 @@ <h3>Open GitHub links in your IDE</h3> | |||
| <option value="phpstorm">PhpStorm</option> | |||
| <option value="intellij-idea">IntelliJ IDEA</option> | |||
| <option value="webstorm">WebStorm</option> | |||
| <option value="pycharm">Pycharm (Built-in web server)</option> | |||
There was a problem hiding this comment.
Suggested change
| <option value="pycharm">Pycharm (Built-in web server)</option> | |
| <option value="pycharm">PyCharm (built-in web server)</option> |
lmichelin
requested changes
Mar 6, 2021
Comment on lines
+75
to
+77
| const Http = new XMLHttpRequest(); | ||
| Http.open("GET", url) | ||
| Http.send(); |
There was a problem hiding this comment.
Suggested change
| const Http = new XMLHttpRequest(); | |
| Http.open("GET", url) | |
| Http.send(); | |
| void fetch(url) |
lmichelin
reviewed
Mar 6, 2021
| @@ -19,6 +19,7 @@ This browser extension allows you to open files in your IDE directly from GitHub | |||
| - VS Code Insiders | |||
| - PhpStorm | |||
| - IntelliJ IDEA | |||
| - Pycharm (Built-in web server) | |||
There was a problem hiding this comment.
Suggested change
| - Pycharm (Built-in web server) | |
| - PyCharm (built-in web server) |
lmichelin
reviewed
Mar 6, 2021
| name: "Pycharm (Built-in web server)", | ||
| icon: "icons/intellij-idea32.png", | ||
| openIDE: (repo: string, file: string, line?: string) => { | ||
| const url = `http://localhost:63342/api/file?file=${OPTIONS.localPathForRepositories}/${repo}/${file}&line=${line ? `${line}` : "1"}` |
There was a problem hiding this comment.
Suggested change
| const url = `http://localhost:63342/api/file?file=${OPTIONS.localPathForRepositories}/${repo}/${file}&line=${line ? `${line}` : "1"}` | |
| const url = `http://localhost:63342/api/file?file=${OPTIONS.localPathForRepositories}/${repo}/${file}&line=${line ?? "1"}` |
lmichelin
reviewed
Mar 6, 2021
| @@ -28,6 +29,8 @@ PhpStorm & IntelliJ IDEA support is native on MacOS, but on Linux and Windows yo | |||
|
|
|||
| I have not tested WebStorm support yet, feedbacks are welcome! | |||
|
|
|||
| If you wish to use Pycharm (Built-in web server) then you must enable the intellij built-in web server (see [here](https://www.jetbrains.com/help/idea/php-built-in-web-server.html#configuring-built-in-web-server)) on port 63342 | |||
There was a problem hiding this comment.
Suggested change
| If you wish to use Pycharm (Built-in web server) then you must enable the intellij built-in web server (see [here](https://www.jetbrains.com/help/idea/php-built-in-web-server.html#configuring-built-in-web-server)) on port 63342 | |
| If you wish to use PyCharm (Built-in web server) then you must enable the intellij built-in web server (see [here](https://www.jetbrains.com/help/idea/php-built-in-web-server.html#configuring-built-in-web-server)) on port 63342. |
|
Thanks @rnw159 for your contribution 😉 I made some updates to your PR in commit 7511be7:
I just published v1.1.7 to Chrome Web Store and Firefox Addons. |
|
Hey thanks for merging! I love this extension 💚 |
lmichelin
added a commit
that referenced
this pull request
Mar 14, 2021
lmichelin
added a commit
that referenced
this pull request
Mar 14, 2021
Enable support for Pycharm using the built-in web server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pycharm has a built-in webserver that makes it easy to open files. I have been using this locally for a while and decided to make a pr to share my work.
Cheers!
There might be better ways to do this, but this works really well for me.