Search index is optional for precomputed_knn #909
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #848 in the sense that it allows passing only indices and distances to as the
precomputed_knn
parameter (i.e. no pynndescent object required). Things to note:transform
method, aNotImplementedError
will be raised.force_approximation_algorithm=False
you will not see the new warning, because the knn will not be used. Settingforce_approximation_algorithm=True
avoids this situation so this new feature works for big and small data.precomputed_knn
parameter on theUMAP
constructor has been updated.Tests successes/warns/failures were the same before and after this addition (there is one failure currently which was failing on upstream-master for me before I added any code). I have added a new test to exercise these various cases.