-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MC][NFC] Statically allocate storage for decoded pseudo probes and function records #102789
Merged
aaupov
merged 11 commits into
main
from
users/aaupov/spr/mcnfc-statically-allocate-storage-for-decoded-pseudo-probes-and-function-records
Aug 26, 2024
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
023e1a4
[𝘀𝗽𝗿] changes to main this commit is based on
aaupov fc9bfe9
[𝘀𝗽𝗿] initial version
aaupov 7771414
[𝘀𝗽𝗿] changes introduced through rebase
aaupov aa535ef
further reduce MCDecodedPseudoProbe and InlineTree structure sizes
aaupov ddcbb59
Pass CurChildIndex by value
aaupov f13f9cd
[𝘀𝗽𝗿] changes introduced through rebase
aaupov 2b56ea1
Comment InjectedProbeMap, refactor MCPseudoProbeInlineTreeBase
aaupov 73d808a
s/ChildrenType/InlinedProbeTreeMap
aaupov 800dfcd
Add asserts, address comments
aaupov fa3b045
[𝘀𝗽𝗿] changes introduced through rebase
aaupov da8aa75
rebase
aaupov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need this change? seems it's not related to decoding pseudo probe, or is it because we allocate a fixed size of
MCDecodedPseudoProbe
, so later there is no way to add additional probe to the vector. To address this, we have to use a new containerInjectedProbeMap
to save new probes. If so, could you add comments to explain this(maybe in the definition ofInjectedProbeMap
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's required because appending to ProbeVec may cause its reallocation so that pointers to its elements will become invalid. I'll leave a comment.