Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC][libc++][test][AIX] UnXFAIL LIT test transform.pass.cpp #102338

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

xingxue-ibm
Copy link
Contributor

Remove XFAIL: LIBCXX-AIX-FIXME from lit test transform.pass.cpp now that AIX system call wcsxfrm/wcsxfrm_l is fixed in AIX 7.2.5.8 and 7.3.2.2 and buildbot machines have been upgraded.

@xingxue-ibm xingxue-ibm added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Aug 7, 2024
@xingxue-ibm xingxue-ibm self-assigned this Aug 7, 2024
@xingxue-ibm xingxue-ibm requested a review from a team as a code owner August 7, 2024 17:34
@llvmbot
Copy link
Collaborator

llvmbot commented Aug 7, 2024

@llvm/pr-subscribers-libcxx

Author: Xing Xue (xingxue-ibm)

Changes

Remove XFAIL: LIBCXX-AIX-FIXME from lit test transform.pass.cpp now that AIX system call wcsxfrm/wcsxfrm_l is fixed in AIX 7.2.5.8 and 7.3.2.2 and buildbot machines have been upgraded.


Full diff: https://github.com/llvm/llvm-project/pull/102338.diff

1 Files Affected:

  • (modified) libcxx/test/std/re/re.traits/transform.pass.cpp (-1)
diff --git a/libcxx/test/std/re/re.traits/transform.pass.cpp b/libcxx/test/std/re/re.traits/transform.pass.cpp
index 369dbdf7053ba..80cd3f01faff2 100644
--- a/libcxx/test/std/re/re.traits/transform.pass.cpp
+++ b/libcxx/test/std/re/re.traits/transform.pass.cpp
@@ -8,7 +8,6 @@
 //
 // NetBSD does not support LC_COLLATE at the moment
 // XFAIL: netbsd
-// XFAIL: LIBCXX-AIX-FIXME
 
 // REQUIRES: locale.cs_CZ.ISO8859-2
 

Copy link
Member

@daltenty daltenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@xingxue-ibm xingxue-ibm merged commit cb5912a into llvm:main Aug 8, 2024
55 checks passed
@xingxue-ibm xingxue-ibm added this to the LLVM 19.X Release milestone Aug 8, 2024
@xingxue-ibm
Copy link
Contributor Author

/cherry-pick cb5912a

@llvmbot
Copy link
Collaborator

llvmbot commented Aug 8, 2024

Failed to cherry-pick: cb5912a

https://github.com/llvm/llvm-project/actions/runs/10302311310

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

xingxue-ibm added a commit to xingxue-ibm/llvm-project that referenced this pull request Aug 8, 2024
…2338)

Remove `XFAIL: LIBCXX-AIX-FIXME` from lit test `transform.pass.cpp` now
that AIX system call `wcsxfrm`/`wcsxfrm_l` is fixed in AIX 7.2.5.8 and
7.3.2.2 and buildbot machines have been upgraded.

Backported from commit cb5912a
tru pushed a commit to xingxue-ibm/llvm-project that referenced this pull request Aug 12, 2024
…2338)

Remove `XFAIL: LIBCXX-AIX-FIXME` from lit test `transform.pass.cpp` now
that AIX system call `wcsxfrm`/`wcsxfrm_l` is fixed in AIX 7.2.5.8 and
7.3.2.2 and buildbot machines have been upgraded.

Backported from commit cb5912a
kstoimenov pushed a commit to kstoimenov/llvm-project that referenced this pull request Aug 15, 2024
…2338)

Remove `XFAIL: LIBCXX-AIX-FIXME` from lit test `transform.pass.cpp` now
that AIX system call `wcsxfrm`/`wcsxfrm_l` is fixed in AIX 7.2.5.8 and
7.3.2.2 and buildbot machines have been upgraded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. release:cherry-pick-failed
Projects
Development

Successfully merging this pull request may close these issues.

4 participants