[llvm-lit] Unhashable TypeError 'GlobItem' with lit’s internal shell #102389
Assignees
Labels
Comments
This was referenced Aug 7, 2024
This was referenced Aug 9, 2024
ilovepi
pushed a commit
that referenced
this issue
Aug 14, 2024
…101590) When using the lit internal shell with the command: ``` LIT_USE_INTERNAL_SHELL=1 ninja check-compiler-rt ``` The follow error is encountered: ``` File "TestRunner.py", line 770, in _executeShCmd inproc_builtin = inproc_builtins.get(args[0], None) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: unhashable type: 'GlobItem' ``` This error is in a compiler-rt file: ``` TestCases/Linux/long-object-path.cpp ``` This error occurs because `args[0]` is of type `GlobItem`, which is not hashable, leading to a `TypeError` when it is passed in `inproc_builtins.get()`. To resolve this issue, I have updated the implementation to ensure that `args[0]` is hashable before it is used in `inproc_builtins`. fixes: #102389 [link to RFC](https://discourse.llvm.org/t/rfc-enabling-the-lit-internal-shell-by-default/80179)
bwendling
pushed a commit
to bwendling/llvm-project
that referenced
this issue
Aug 15, 2024
…lvm#101590) When using the lit internal shell with the command: ``` LIT_USE_INTERNAL_SHELL=1 ninja check-compiler-rt ``` The follow error is encountered: ``` File "TestRunner.py", line 770, in _executeShCmd inproc_builtin = inproc_builtins.get(args[0], None) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: unhashable type: 'GlobItem' ``` This error is in a compiler-rt file: ``` TestCases/Linux/long-object-path.cpp ``` This error occurs because `args[0]` is of type `GlobItem`, which is not hashable, leading to a `TypeError` when it is passed in `inproc_builtins.get()`. To resolve this issue, I have updated the implementation to ensure that `args[0]` is hashable before it is used in `inproc_builtins`. fixes: llvm#102389 [link to RFC](https://discourse.llvm.org/t/rfc-enabling-the-lit-internal-shell-by-default/80179)
Harini0924
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The RUN: lines in the
long-object-path.cppfile are encountering unhashable type errors forGlobIteminstances. This issue occurs due to improper handling ofGlobIteminstances within the test execution logic, specifically in the_executeShCmdfunction in lit'sTestRunner.py.The error is encountered in the
TestRunner.pyfile, specifically within the_executeShCmdfunction at line 770:inproc_builtin = inproc_builtins.get(args[0], None)Error Displayed:
The text was updated successfully, but these errors were encountered: