Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json sideEffects should be boolean #2

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

patrickmichalina
Copy link
Contributor

No description provided.

@ljharb
Copy link
Owner

ljharb commented Jan 11, 2024

lol whoops, thanks. how'd you notice this?

Copy link

codecov bot commented Jan 11, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@ljharb ljharb merged commit 094bb88 into ljharb:main Jan 11, 2024
319 of 320 checks passed
@patrickmichalina
Copy link
Contributor Author

lol whoops, thanks. how'd you notice this?

esbuild was sure to inform me :)

@patrickmichalina patrickmichalina deleted the patch-1 branch January 11, 2024 18:06
@ljharb
Copy link
Owner

ljharb commented Jan 11, 2024

@patrickmichalina thanks, i had no idea it checked that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants