ES6 style changes and node v4

[hueniverse]

The hapi world is moving to only support node >= 4.0. This module is part of that world. I want to make sure the express community is aware of it as they are a significant user of this module. Also, this will affect use in the browser in pre-ES6 versions.

@dougwilson

[dougwilson]

Hi @hueniverse , that sounds fine to me. We have no timeline to drop 0.10, unfortunately, and so we'll likely just fork this module for our ecosystems, if it becomes necessary. Likely, we'll sit on an old version unless there is some security issue :)

[hueniverse]

If there are security issues we'll publish a 5.x patch since hapi 9.x will need it too.

[dougwilson]

Even better :) Don't let us hold ya back ;)

[taion]

This is fairly unfriendly to people using this library v. e.g. browserify or webpack.

Have you considered still including a transpiled build in the npm package, then pointing the "browser" key in package.json to that?

[Marsup]

This is fairly unfriendly to force maintainers to also maintain builds while you can make it yourself.

[taion]

Aren't you already maintaining a browser package at dist/qs.js? It looks like it hasn't been updated for 6.x yet and is still on 5.2.0, but you're going to have to pull in babelify to produce an updated browser bundle for 6.x that will actually run in browsers.

Either way, the reason this comes up is because in general when producing browser bundles, best practice is to exclude anything from node_modules for transpilation to avoid any dependencies on how exactly people are configuring Babel.

I like the approach you're taking with moving to use Node's ES6-supported features for Node code. It wouldn't be the end of the world if you dropped browser support in this library entirely, but right now you're actually shipping broken/outdated browser support via the distributed bundle, and would need to bring in Babel yourself to properly ship that bundle.

[nlf]

You're right it is silly that we have an outdated browser build, but that's also why I have an open issue to remove that build. If you'd like to see browser support continued here, I'd be happy to hand the module over to you

[taion]

I just saw that issue, sorry.

I have a few more JS packages than I can get around to maintaining at the moment, unfortunately, but I'd be happy to contribute a PR that fixes the browser build if that's something you're interested in.

[nlf]

I'm more inclined to accept a PR removing all the current browser support

[taion]

I see - thanks.

[evantahler]

Thanks for keeping v5.x around, and offering to publish security patches if they come up. Actionhero just switched to this library as well, and it's great! That said, we'll still be supporting node v0.10+ for another few months...

[mmahalwy]

I am having problems with this library breaking my tests cause I don't intend to bundle node_modules...

[ljharb]

It's very sad to have a module that is published in such a way that it requires transpilation to be used in a browser or older node environment. Why is it difficult to add a babel prepublish step?

[devinivy]

@ljharb feel free to check-out the discussion around this at outmoded/hapi-contrib#67

[ljharb]

Thanks, commented outmoded/hapi-contrib#67 (comment)

[hueniverse]

use version 5. I'm locking this issue