Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send link navigation event inside iframe to parent #2160

Merged
merged 2 commits into from
Aug 13, 2023

Conversation

jannikbecher
Copy link
Contributor

When clicking on links inside a rendered iframe it navigates to the link and renders it inside the iframe.
I think a more expected behavior would be to open that link in the parent window :)

@github-actions
Copy link

github-actions bot commented Aug 13, 2023

Uffizzi Preview deployment-33324 was deleted.

Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@jonatanklosko jonatanklosko merged commit 60d9bed into livebook-dev:main Aug 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants