Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Original identities not respected in ATAC analysis #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Original identities not respected in ATAC analysis #117

wants to merge 1 commit into from

Conversation

f6v
Copy link

@f6v f6v commented Feb 17, 2021 •
edited
Loading

I noticed that unlike RNA analysis, the original identities aren't assigned to the Seurat object when using ATACRunSeurat. I propose to add the same behaviour where:

  • The orig.ident is assigned to to SeuratObject
  • The UMAP plot coloured by the orig.ident is saved
    There was also a minor discrepancy in the param name: orig.ident in RNA and orign.ident in the ATAC function.

@f6v
Original identities not respected in ATAC analysis
93bbef8 
I noticed that unlike RNA analysis, the original identities aren't assigned to the Seurat object when using `ATACRunSeurat`. I propose to add the same behaviour where:
- The `orig.ident` is assigned to to `SeuratObject`
- The UMAP plot coloured by the `orig.ident` is saved
There was also a minor discrepancy in the param name: `orig.ident` in RNA and ``orign.ident` in the ATAC function.
@f6v
Copy link
Author

f6v commented Mar 19, 2021

@DongqingSun96 @baigal628 does this look fine to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@f6v