Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test (addColumnFailIfNoPT) #424

Merged
merged 8 commits into from
Mar 27, 2024

Conversation

adangel
Copy link
Collaborator

@adangel adangel commented Mar 23, 2024

This changes the way, how a missing percona toolkit is reported.
Previously just a UnexpectedLiquibaseException was thrown, now the existence of percona toolkit is tested via validate().

If percona toolkit is missing and liquibase-percona should fail, then a validation error is reported. Otherwise just a warning.

Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@filipelautert filipelautert self-requested a review March 25, 2024 16:49
@adangel adangel added this to the next milestone Mar 27, 2024
@adangel adangel merged commit e4e35cf into liquibase:main Mar 27, 2024
27 checks passed
@adangel adangel deleted the failIfNoPT-as-ValidationError branch April 25, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants