Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAT-18153: Make multiplatform checks extension workflow work with PRs #228

Merged
merged 8 commits into from
Jul 17, 2024

Conversation

abrackx
Copy link
Contributor

@abrackx abrackx commented Jul 16, 2024

Keeps most of the same behavior but hardcodes less things. inputs.version was required, but there were a lot of places that had if: !inputs.version, so i removed these.

Here's an outline of what this does:

  1. Check out liquibase oss and pro on appropriate branches (now workflow inputs).
  2. Build liquibase oss and core to get the necessary dependencies to build liquibase-checks. We are building this without setting any versions, so this will be installed under version 0-SNAPSHOT in this workflow. The true version will correspond to the input branches.
  3. Build liquibase-checks for each platform
  4. Upload each of the platforms liquibase-checks jars to the workflow. << ✨ new
  5. After this workflow has completed for windows, linux and macos we kick off a new workflow to combine these. This workflow effectively unzips each jar on top of each other.
  6. Once we have a new multiplatform jar we set the version of this jar to the workflow's input version inputs.version. This will be the branch name in the liquibase-checks repo, but can be set via workflow dispatch. (<< ✨ new)
  7. Upload this versioned jar to GPM and the workflow (<< ✨ new).

With corresponding updates to the liquibase-checks repo we now have something that should generate workflow and GPM multiplatform snapshot artifacts for both prs and merges to main.

This branch was supposed to be DAT-18153.

@abrackx abrackx added the sdou label Jul 16, 2024
@abrackx abrackx self-assigned this Jul 16, 2024
@sayaliM0412 sayaliM0412 marked this pull request as draft July 16, 2024 15:10
@abrackx abrackx changed the title DAT-18178: Fix artifact name DAT-18178: Make multiplatform checks extension workflow work with PRs Jul 16, 2024
@abrackx abrackx marked this pull request as ready for review July 16, 2024 19:13
@abrackx abrackx changed the title DAT-18178: Make multiplatform checks extension workflow work with PRs DAT-18153: Make multiplatform checks extension workflow work with PRs Jul 17, 2024
@abrackx abrackx merged commit 2ec5e45 into main Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants