os-extension-test: fix checkout ref #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests are now running against the PR code and not main branch.
adangel
commented
May 23, 2024
| @@ -154,6 +154,8 @@ jobs: | |||
| needs: build | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| with: | |||
| ref: ${{ github.event.pull_request.head.sha || github.ref }} | |||
There was a problem hiding this comment.
Maybe it's better to use ${{ github.ref }} only - the difference is, that "github.event.pull_request.head.sha" is the head commit of the PR, but "github.ref" will be the "pull request merge branch" - that is a temporary merge of the PR into main. This is usually, what we want, as we want to test the integration of the PR with the main branch. Otherwise we might merge the PR but the project will be broken, because the merged PR was never tested.
If this is changed here, then it must also be changed on line 42.
filipelautert
approved these changes
May 28, 2024
|
Thanks @adangel !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are now running against the PR code and not main branch.
Before that, the tests of the main branch were run, but not the PR tests... that caused e.g. that the automerge of liquibase/liquibase-percona#457 failed the build.