Skip to content

Commit

Permalink
Fix nightly builds (#173)
Browse files Browse the repository at this point in the history
* chore(pro-extension-test.yml): update descriptions to use double quotes for consistency
chore(pro-extension-test.yml): update MAVEN_VERSION value to use double quotes
chore(pro-extension-test.yml): update distribution and cache values to use double quotes
chore(pro-extension-test.yml): update if conditions to use double quotes
chore(pro-extension-test.yml): update SLACK_MESSAGE and SLACK_TITLE to use double quotes
chore(pro-extension-test.yml): update SLACK_ICON_EMOJI and SLACK_FOOTER to use double quotes
feat(pro-extension-test.yml): add support for running tests with liquibase master-SNAPSHOT version when nightly flag is set

* chore(os-extension-test.yml): update descriptions in workflow inputs to use double quotes for consistency
chore(os-extension-test.yml): update Maven version environment variable to use double quotes
chore(os-extension-test.yml): update setup-java and setup-maven actions to use double quotes for distribution and cache
chore(os-extension-test.yml): update Slack notification messages to use double quotes for consistency
chore(os-extension-test.yml): update setup-java and setup-maven actions in matrix to use double quotes for distribution and cache

* chore(os-extension-test.yml): update liquibase version parameter to be enclosed in quotes for consistency and to prevent potential issues with special characters.

* chore(pro-extension-test.yml): wrap liquibase version argument in quotes to ensure proper parsing and prevent issues with special characters
  • Loading branch information
jandroav committed Mar 4, 2024
1 parent 3dc125b commit 3666749
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pro-extension-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:
- name: Build and Package latest liquibase version
if: ${{ inputs.nightly }}
run: mvn -B dependency:go-offline clean package -DskipTests=true -Dliquibase.version=master-SNAPSHOT
run: mvn -B dependency:go-offline clean package -DskipTests=true "-Dliquibase.version=master-SNAPSHOT"

- name: Notify Slack on Build Failure
if: ${{ failure() && inputs.nightly }}
Expand Down Expand Up @@ -241,7 +241,7 @@ jobs:

- name: Run Tests
if: ${{ inputs.nightly }}
run: mvn -B test -P 'coverage' ${{ inputs.extraMavenArgs }} -Dliquibase.version=master-SNAPSHOT
run: mvn -B test -P 'coverage' ${{ inputs.extraMavenArgs }} "-Dliquibase.version=master-SNAPSHOT"

- name: Notify Slack on Build Failure
if: ${{ failure() && inputs.nightly }}
Expand Down

0 comments on commit 3666749

Please sign in to comment.