This repository has been archived by the owner on Nov 23, 2023. It is now read-only.
feat: Lint Dockerfiles #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imincik
suggested changes
Jan 7, 2021
| @@ -1,19 +1,26 @@ | |||
| FROM ubuntu:20.04 as build | |||
|
|
|||
| RUN apt-get update \ | |||
| && apt-get install -y curl python3-pip \ | |||
| && apt-get install --assume-yes --no-install-recommends curl=7.68.0-1ubuntu2.4 python3-pip=20.0.2-5ubuntu1.1 \ | |||
There was a problem hiding this comment.
Apt package versions as above
| @@ -1,6 +1,8 @@ | |||
| FROM ubuntu:20.04 | |||
| ENV DEBIAN_FRONTEND noninteractive | |||
| RUN apt update && apt install -y python3 && rm -rf /var/lib/apt/lists/* | |||
| RUN apt-get update \ | |||
| && apt-get install --assume-yes --no-install-recommends python3=3.8.2-0ubuntu2 \ | |||
There was a problem hiding this comment.
@l0b0 , are you sure we need to specify apt packages versions here ? The only distribution upgrades are bug fixes. I think this is not necessary.
There was a problem hiding this comment.
Pro locking versions:
- Makes it less likely to break things arbitrarily. Even OS package patches sometimes sneak in functional changes which impact systems. Reproducibility is a huge win.
Cons:
- Even if we install fixed versions of the top level packages, we might get updated versions of their dependencies. Apt AFAIK does not have a lockfile mechanism like NPM and Poetry, meaning that locking all the package dependencies is a bit more of a chore.
- Dependabot does not yet patch Dockerfile package installs.
Once Dependabot supports apt-get within Dockerfiles that fixes both of the above - we could just lock the package dependencies in the apt-get command once and Dependabot would take care of keeping them up to date. So on balance I agree for now. Documented.
|
|
||
|
|
||
| FROM ubuntu:20.04 | ||
|
|
||
| ENTRYPOINT ["/opt/.venv/bin/python", "/opt/task.py"] | ||
|
|
||
| ENV DEBIAN_FRONTEND noninteractive | ||
| RUN apt-get update && apt-get install -y python3 && rm -rf /var/lib/apt/lists/* | ||
| RUN apt-get update \ | ||
| && apt-get install --assume-yes --no-install-recommends python3=3.8.2-0ubuntu2 \ |
There was a problem hiding this comment.
Apt package versions as above
Ignore rule to force setting specific package versions since - Ubuntu should only be receiving non-breaking patches, - we don't want the overhead of having to follow up on every package upgrade manually (see dependabot/dependabot-core#2129), and - locking only the top level packages means we'd still get arbitrary versions of their dependencies.
imincik
approved these changes
Jan 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.