feat: add optional --fix-content-type TDE-859 #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amfage
reviewed
Sep 14, 2023
Co-authored-by: Alice Fage <afage@linz.govt.nz>
amfage
previously approved these changes
Sep 14, 2023
blacha
reviewed
Sep 25, 2023
README.md
Outdated
|
|
||
| #### Example | ||
|
|
||
| - Format and overwrite files: | ||
|
|
||
| ```bash | ||
| pretty-print source/ | ||
| format-json source/ [--fix-content-type] |
There was a problem hiding this comment.
How come the name change? prettier will format a lot more than json. eg markdown, yaml, javascript etc..
There was a problem hiding this comment.
Because it's looking for json files atm. I can make the function more generic and look at other file format but I feel it will need a bit more work, specially around the --fix-content-type
There was a problem hiding this comment.
This is a breaking change to rename it, so Id prefer to leave it as is if we can?
l0b0
reviewed
Nov 15, 2023
|
|
||
| #### Example | ||
|
|
||
| - Format and overwrite files: | ||
|
|
||
| ```bash | ||
| pretty-print source/ | ||
| pretty-print source/ [--fix-content-type] |
There was a problem hiding this comment.
The flag should be before the directory.
l0b0
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an option
--fix-content-typeinformat-json(previouslypretty-print) to force the content-type to be updated for json s3 objects.Intention
Some of the STAC files (
Item) have a content-type set toapplication/jsoninstead ofapplication/geo+json.Checklist
If not applicable, provide explanation of why.