[WIP] Some adjustments for the new version of cmenu #8947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The majority of these changes are due to the change in prefix from gmenu_* to cmenu_*, though support for inlining and separators were also removed since we don't use those in Cinnamon anyway. CMenu now also flattens the menu structure and performs a sort, so we don't need to do that in Cinnamon any more.
collinss
force-pushed
the
cmenu-refactor-adjustments
branch
from
68b6966
to
3cd63a8
Compare
|
Complexity decreasing per file
==============================
+ files/usr/share/cinnamon/cinnamon-menu-editor/cme/MainWindow.py -5
See the complete overview on Codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of these changes are due to the change in prefix from gmenu_* to cmenu_*, though support for inlining and separators were also removed since we don't use those in Cinnamon anyway. CMenu now also flattens the menu structure and performs a sort, so we don't need to do that in Cinnamon any more.
Requires linuxmint/cinnamon-menus#29