Fix JUMP TO #1713
Merged
Fix JUMP TO #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
abemassry
approved these changes
May 8, 2017
eatonphil
reviewed
May 8, 2017
docs/src/App.js
Outdated
| const id = hash.replace('#', ''); | ||
| const element = document.getElementById(id); | ||
| if (element) { | ||
| element.scrollIntoView(); |
There was a problem hiding this comment.
window.scrollBy(0, -60); afterward?
|
Made a PR to your branch with minor enhancements mparke#16 |
Scroll enhancements
eatonphil
reviewed
May 9, 2017
docs/src/App.js
Outdated
| export function init() { | ||
| setTimeout(() => hashLinkScroll(), 0); |
There was a problem hiding this comment.
Ugh, missed it: setTimeout(hashLinkScroll, 0)
mparke
pushed a commit
to mparke/manager
that referenced
this pull request
May 16, 2017
* Fix JUMP TO * use var * Account for header in scroll and scroll to section not header * remove uneeded function * Call without timeout * Use scrollTop and offsetHeight instead
mparke
pushed a commit
to mparke/manager
that referenced
this pull request
May 17, 2017
* Fix JUMP TO * use var * Account for header in scroll and scroll to section not header * remove uneeded function * Call without timeout * Use scrollTop and offsetHeight instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1670
Fixes JUMP TO links and adds ids to methods