Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poc: Autocomplete Popover fix #10978

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bnussman-akamai
Copy link
Contributor

Description 📝

Side tangent

  • Looking back refactor: [M3-6908] - Replace react-select in Profile #10780 more things should have been caught in PR review. The PR does a good job attempting to be in parity with the old UI, but
    • It modifies a core component and we should have caught that there was probably a better way to approach it
    • It uses far too many one-off styled (in my opinion). I get that the PhoneVerification needs it because the UI is very demanding, but I'm not sure I agree with one-off styling the Expiry field in the API Token Drawer. The argument could be made our component library isn't great, which is why all of the one-off styled are needed, which is true and fair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants