Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8125] Remove and Prevent tooltip disableInteractive #10501

Merged
merged 3 commits into from
May 22, 2024

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented May 21, 2024

Description 📝

In a recent user session, we were made aware that our tooltip are not accessible because often having the disableInteractive prop passed to them.

Makes a tooltip not interactive, i.e. it will close when the user hovers over the tooltip before the leaveDelay is expired.

As a result, users complained they were unable to copy the test within tooltips to translate it (google translate or else).

While not having translations in Cloud Manager, this is an accessibility issue we can easily fix by removing this setting and making sure all tooltips are interactive. It does not seem to have any huge drawback to keep interactivity enabled by default for all tooltips (as far as we were able to tell) and the resulting behavior appears to outweigh any potential behavioral change in the way users interact with tooltips.

Changes 🔄

  • Remove disableInteractive from tooltip and parent components
  • Prevent being able to se disableInteractive via types

Verification steps

  • Check the general behavior of tooltips through the app
  • Confirm the change isn't disruptive

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@abailly-akamai abailly-akamai added the Accessibility Contains accessibility improvements or changes label May 21, 2024
@abailly-akamai abailly-akamai self-assigned this May 21, 2024
@abailly-akamai abailly-akamai marked this pull request as ready for review May 21, 2024 20:45
@abailly-akamai abailly-akamai requested a review from a team as a code owner May 21, 2024 20:45
@abailly-akamai abailly-akamai requested review from jdamore-linode and hkhalil-akamai and removed request for a team May 21, 2024 20:45
Copy link

github-actions bot commented May 21, 2024

Coverage Report:
Base Coverage: 81.64%
Current Coverage: 81.64%

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label May 22, 2024
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for such a quick turnaround on that user feedback!

Spot checked some of our tooltips to confirm they're interactive, users will be able to copy and paste tooltip text content, and this isn't creating any issues navigating CM.

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels May 22, 2024
@abailly-akamai abailly-akamai merged commit 0d03587 into linode:develop May 22, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Contains accessibility improvements or changes Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants