Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-8129] - Temporarily disable form event analytics #10498

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented May 21, 2024

Description 📝

With our first implementation of form events (#10392) , there were some additional changes required that were not known in the initial implementation of code for the form event analytics. The working form events were reviewed by Front End and UX, but missing a complete MADS QA after added to the UI. (In the future, we will work this step into our review process for new/more complex analytics events to ensure this doesn't happen again.)

A MADS review of the changes was done after the PR was already merged, and changes requested are listed in the ticket tied to this subtask (M3-8126). While we work to clarify and confirm final changes, we need to stop the form analytics in develop from being released to prod. This subtask disables those events for now, since the release branch will be cut soon.

Changes 🔄

  • Comments out the _satellite.track direct call rule that fires the form analytics events to prevent form analytics data from being sent to Adobe.

Target release date 🗓️

05/28

How to test 🧪

Prerequisites

(How to setup test environment)

  • Follow the instructions in the developer's guide to enable Adobe event logging in the browser console.

Verification steps

(How to verify changes)

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@mjac0bs mjac0bs self-assigned this May 21, 2024
@mjac0bs mjac0bs requested a review from a team as a code owner May 21, 2024 19:39
@mjac0bs mjac0bs requested review from hana-linode and jaalah-akamai and removed request for a team May 21, 2024 19:39
@mjac0bs mjac0bs added Ready for Review Analytics Relating to Analytics migration project or Adobe Analytics labels May 21, 2024
Copy link

Coverage Report:
Base Coverage: 81.62%
Current Coverage: 81.62%

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Ready for Review labels May 22, 2024
@mjac0bs mjac0bs merged commit b774f62 into linode:develop May 22, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics Relating to Analytics migration project or Adobe Analytics Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants