-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-6226] - Clean up cy.intercept calls in notification and events #10472
test: [M3-6226] - Clean up cy.intercept calls in notification and events #10472
Conversation
Coverage Report: ✅ |
Quick Cypress tip! You can run multiple specs with one yarn cy:run -s "cypress/e2e/core/notificationsAndEvents/*" and: yarn cy:run -s "cypress/e2e/core/notificationsAndEvents/events.spec.ts,cypress/e2e/core/notificationsAndEvents/notifications.spec.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks @AzureLatte!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Azure! Looks good on a local run.
using either wildcards
@jdamore-linode I don't think I knew this about wildcards, and I don't know why I never tried! 🤦🏼♀️
@AzureLatte One other thing I was going to mention was the github markdown tip of enclosing code in ``` the three backticks to make them copyable (like Joe did in his comment above), which is really convenient for test commands in particular. (TIL these are called fenced code blocks.)
```
<command here>
```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Description 📝
Clean up cy.intercept calls in notification and events
Changes 🔄
List any change relevant to the reviewer.
Replace calls to cy.intercept with intercept utils in events.ts
How to test 🧪
We can rely on CI to confirm that this test has not been broken by these changes, but to run the test locally you can use this command:
As an Author I have considered 🤔
Check all that apply