Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-6226] - Clean up cy.intercept calls in notification and events #10472

Conversation

AzureLatte
Copy link
Contributor

@AzureLatte AzureLatte commented May 15, 2024

Description 📝

Clean up cy.intercept calls in notification and events

Changes 🔄

List any change relevant to the reviewer.

Replace calls to cy.intercept with intercept utils in events.ts

How to test 🧪

We can rely on CI to confirm that this test has not been broken by these changes, but to run the test locally you can use this command:

yarn cy:run -s "cypress/e2e/core/notificationsAndEvents/*"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@AzureLatte AzureLatte requested a review from a team as a code owner May 15, 2024 17:26
@AzureLatte AzureLatte requested review from cliu-akamai and removed request for a team May 15, 2024 17:26
@AzureLatte AzureLatte self-assigned this May 15, 2024
@AzureLatte AzureLatte requested review from a team, hkhalil-akamai, jaalah-akamai and jdamore-linode and removed request for a team May 15, 2024 17:26
@AzureLatte AzureLatte requested a review from a team as a code owner May 15, 2024 17:27
@AzureLatte AzureLatte requested review from bnussman-akamai and abailly-akamai and removed request for a team May 15, 2024 17:27
Copy link

github-actions bot commented May 15, 2024

Coverage Report:
Base Coverage: 82.01%
Current Coverage: 82.01%

@jdamore-linode
Copy link
Contributor

We can rely on CI to confirm that this test has not been broken by these changes, but to run the test locally you can use this command:
yarn cy:run -s "cypress/e2e/core/notificationsAndEvents/events.spec.ts"
yarn cy:run -s "cypress/e2e/core/notificationsAndEvents/notifications.spec.ts"

Quick Cypress tip! You can run multiple specs with one yarn cy:run call using either wildcards or comma-separated paths, like this:

yarn cy:run -s "cypress/e2e/core/notificationsAndEvents/*"

and:

yarn cy:run -s "cypress/e2e/core/notificationsAndEvents/events.spec.ts,cypress/e2e/core/notificationsAndEvents/notifications.spec.ts"

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks @AzureLatte!

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Azure! Looks good on a local run.

image

using either wildcards

@jdamore-linode I don't think I knew this about wildcards, and I don't know why I never tried! 🤦🏼‍♀️

@AzureLatte One other thing I was going to mention was the github markdown tip of enclosing code in ``` the three backticks to make them copyable (like Joe did in his comment above), which is really convenient for test commands in particular. (TIL these are called fenced code blocks.)

```
<command here>
```

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels May 15, 2024
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@AzureLatte AzureLatte merged commit c4be46e into linode:develop May 16, 2024
18 checks passed
@AzureLatte AzureLatte deleted the M3-6226-refactor-notification-and-events-e2e-test-intercepts branch May 16, 2024 13:25
@AzureLatte AzureLatte added Clean Up and removed Approved Multiple approvals and ready to merge! labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants