Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-8009] - Upgrade country-region-data to 3.0.0 #10464

Merged
merged 3 commits into from
May 16, 2024

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented May 14, 2024

Description 📝

Small PR to update country-region-data to the latest version. Benefits:

  • Smaller, tree shakable format
  • ES6 import Type support
  • Latest country data

Changes 🔄

  • Update to 3.0.0
  • Update code shape according to new types

Preview 📷

No visual change expected as part of this refactor.

Before After
Screenshot 2024-05-14 at 11 47 21 Screenshot 2024-05-14 at 11 47 36

How to test 🧪

Verification steps

ℹ️ Compare billing info panels and edit flow with PROD:

  • Navigate to http://localhost:3000/account/billing
    • Confirm the "Billing Contact" panel information
  • Click on "Edit" in the "Billing Contact" panel
    • Confirm the form data
    • Select United States and
      • Confirm US states are listing corectly
      • Confirm "Virgin Islands" is listed as "Virgin Islands, U.S.
      • Confirm 'Micronesia', 'Marshall Islands' and 'Palau' are not listed as regions (states)

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this May 14, 2024
@abailly-akamai abailly-akamai changed the title change: [M3-8009] - Upgrade country-region-data change: [M3-8009] - Upgrade country-region-data t0 3.0.0 May 14, 2024
@abailly-akamai abailly-akamai changed the title change: [M3-8009] - Upgrade country-region-data t0 3.0.0 change: [M3-8009] - Upgrade country-region-data to 3.0.0 May 14, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All types can be inferred now

@abailly-akamai abailly-akamai marked this pull request as ready for review May 14, 2024 18:27
@abailly-akamai abailly-akamai requested a review from a team as a code owner May 14, 2024 18:27
@abailly-akamai abailly-akamai requested review from hana-linode and AzureLatte and removed request for a team May 14, 2024 18:27
Copy link

github-actions bot commented May 14, 2024

Coverage Report:
Base Coverage: 82.01%
Current Coverage: 82.01%

Copy link
Contributor

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't spot any regressions ✅ 👁️

Copy link
Contributor

@hana-linode hana-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm 'Micronesia', 'Marshall Islands' and 'Palau' are not listed as regions (states)

I am seeing these listed as countries and states

Country State
Screen.Recording.2024-05-15.at.11.47.51.AM.mov
Screen.Recording.2024-05-15.at.11.45.04.AM.mov

@abailly-akamai
Copy link
Contributor Author

@hana-linode you're right! fixed in dc10b61

@hana-linode hana-linode added the Approved Multiple approvals and ready to merge! label May 15, 2024
@abailly-akamai abailly-akamai merged commit d2f3e8c into linode:develop May 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Tech Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants