Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-8096] - Update Storybook to 8.1.0 #10463

Conversation

bnussman-akamai
Copy link
Contributor

Description 📝

  • Updates Storybook to latest ⬆️

Significant Changes

How to test 🧪

  • Verify Storybook works as expected locally
  • Verify Storybook build works (see Github Actions)

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added Dependencies Pull requests that update a dependency file Storybook labels May 14, 2024
@bnussman-akamai bnussman-akamai self-assigned this May 14, 2024
@bnussman-akamai bnussman-akamai marked this pull request as ready for review May 14, 2024 15:13
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner May 14, 2024 15:13
@bnussman-akamai bnussman-akamai requested review from mjac0bs, hkhalil-akamai and abailly-akamai and removed request for a team May 14, 2024 15:13
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and storybook is looking good! Curious as to why the changes to some of the component stories were required -- was it a breaking change in storybook?

@bnussman-akamai
Copy link
Contributor Author

I think there was a breaking change with the TypeScript types specifically @hkhalil-akamai

@jdamore-linode jdamore-linode self-requested a review May 14, 2024 16:27
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @bnussman-akamai! Storybook seems to be working as expected with the updated packages, and I confirmed that the test failures can be disregarded 👍

@bnussman-akamai bnussman-akamai merged commit a1e98d4 into linode:develop May 14, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file Storybook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants