-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7993] - PlacementGroups Select optimizations & cleanup #10455
Conversation
packages/manager/src/features/Linodes/LinodeCreatev2/Details/PlacementGroupPanel.tsx
Outdated
Show resolved
Hide resolved
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for addressing this stuff
const [ | ||
selectedPlacementGroup, | ||
setSelectedPlacementGroup, | ||
] = React.useState<PlacementGroup | null>(null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
packages/manager/src/features/PlacementGroups/PlacementGroupsDetailPanel.tsx
Outdated
Show resolved
Hide resolved
Nice clean up! Verified that Placement Groups functionality worked as expected using both versions of the Linode Create Flow. |
Description 📝
This PR addresses small tech debt left by iterations on the PlacementGroupSelect component and related utils.
Changes 🔄
PlacementGroupSelect
now filters PGs via query instead of client-sidePlacementGroupSelect
props and remove what's unusedPlacementGroupDetailPanel
selectedPlacementGroupId
rather than the whole PG object for prop drillinguseAllPlacementGroupsQuery
query to take a filterPlacementGroupSelect
noOptionsMessage
Preview 📷
There should be no visual change as a result of this PR
How to test 🧪
ℹ️ Test in ALPHA
Verification steps
As an Author I have considered 🤔
Check all that apply