e2e tests maintenance #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following has been done: - Ginkgo is properly installed if missing - Old README is removed, a TBD is placed - Removed unused terraform installation - Removed github.com/pkg/errors - Remove --progress Did _not_ do: - Update Go in go.mod - Bump deps for ginkgo and gomega - could not because of other old dependencies - Run tests in parallel - we don't have them set up for that (is that even possible?) - Added golangci-lint for our tests directory
Merged
tchinmai7
approved these changes
Dec 29, 2023
luthermonson
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I understand a lot more will be done as part of #145, I just wanted to clear this up a bit.)
The following has been done:
fmt.Errorfgo-shin favour ofos/execDid not do: