Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add retry on flaky tests #647

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

ykim-1
Copy link
Contributor

@ykim-1 ykim-1 commented Sep 19, 2024

📝 Description

Following list of tests failed occasionally in recent builds, refer to TOD for details.

  • test_rebuild_fails_without_image

  • test_resize_fails_to_the_same_plan

  • test_list_kubernetes_endpoint

  • test_shutdown_linode

This PR uses existing pytest library called pytest-rerunfailures to rerun tests with delay. Flaky tests now can simply be marked with
@pytest.mark.flaky(reruns=3, reruns_delay=2)

✔️ How to Test

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-1 ykim-1 added the testing for updates to the testing suite in the changelog. label Sep 19, 2024
@ykim-1 ykim-1 requested a review from a team as a code owner September 19, 2024 21:40
@ykim-1 ykim-1 requested review from lgarber-akamai and zliang-akamai and removed request for a team September 19, 2024 21:40
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are green when running the suite locally, nice work!

@ykim-1 ykim-1 merged commit 4a3f37d into linode:dev Sep 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants