Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update volume tests to reflect new threshold values for sizing #646

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

ykim-1
Copy link
Contributor

@ykim-1 ykim-1 commented Sep 19, 2024

📝 Description

Recently resize limits have been changed. E.g. 10240GB to 16384GB. This PR addresses this change in assertions and also fix failures related to "unique label"

✔️ How to Test

make MODULE="volumes" testint

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-1 ykim-1 added the testing for updates to the testing suite in the changelog. label Sep 19, 2024
@ykim-1 ykim-1 requested a review from a team as a code owner September 19, 2024 17:36
@ykim-1 ykim-1 requested review from jriddle-linode and lgarber-akamai and removed request for a team September 19, 2024 17:36
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing on my end, great work!

Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykim-1 ykim-1 merged commit b85cc93 into linode:dev Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants