test: fix unit tests to not overwrite existing cli config file #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykim-1
requested review from
jriddle-linode and
zliang-akamai
and removed request for
a team
ykim-1
changed the title
zliang-akamai
approved these changes
Sep 16, 2024
yec-akamai
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Running unit tests caused existing config in
~/.config/linode-clito be overwritten, this PR fixes this issue by setting the environment variable prior to the test execution so the config file will get written in temporary location. After the execution the environment variable will be reverted to original value.✔️ How to Test
LINODE_CLI_TOKENmake installlinode-cli linodes ls- Expected to failmake testunit📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.