Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test placement #636

Merged
merged 27 commits into from
Aug 30, 2024
Merged

Test placement #636

merged 27 commits into from
Aug 30, 2024

Conversation

vshanthe
Copy link
Contributor

@vshanthe vshanthe commented Aug 21, 2024

📝 Description

Added Tests for Placement Groups

✔️ How to Test

make MODULE=placements testint

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@vshanthe vshanthe requested a review from a team as a code owner August 21, 2024 13:50
@vshanthe vshanthe requested review from jriddle-linode and lgarber-akamai and removed request for a team August 21, 2024 13:50
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you get a chance could you run make format to fix the lint error? 👀

@vshanthe vshanthe added the testing for updates to the testing suite in the changelog. label Aug 22, 2024
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing on my end using make MODULE=placements testint, great work!

@vshanthe vshanthe requested a review from ykim-1 August 23, 2024 04:33
Copy link
Contributor

@ykim-1 ykim-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like all the commands are covered. Excellent work!

@vshanthe vshanthe merged commit 5e6003b into linode:dev Aug 30, 2024
5 checks passed
@vshanthe vshanthe deleted the test_placement branch August 30, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants