Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suppress-version-warning config option #635

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

jriddle-linode
Copy link
Contributor

@jriddle-linode jriddle-linode commented Aug 16, 2024

📝 Description

What does this PR do and why is this change necessary?

Adds get_bool('value') method for configuration options and adds a step in configuration to support suppress-version-warning.
Also adds support for LINODE_CLI_SUPPRESS_VERSION_WARNING environment variable.

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?

  1. Install the new version of the CLI
make install
  1. Go through the configuration process
lin configure
  1. The last question should ask you about suppressing API Version Warnings
  2. Use the CLI and see if you view this warning

Environment variable

  1. Install the new CLI or delete the value from your config
  2. Use the cli after setting the environment variable
export LINODE_CLI_SUPPRESS_VERSION_WARNING=true
lin linodes ls
unset $LINODE_CLI_SUPPRESS_VERSION_WARNING
lin linodes ls
  1. Verify the output doesn't have the error.

How do I run the relevant unit/integration tests?

make testunit

resolves #582

@jriddle-linode jriddle-linode added the new-feature for new features in the changelog. label Aug 16, 2024
@jriddle-linode jriddle-linode marked this pull request as ready for review August 20, 2024 20:14
@jriddle-linode jriddle-linode requested a review from a team as a code owner August 20, 2024 20:14
@jriddle-linode jriddle-linode requested review from lgarber-akamai and zliang-akamai and removed request for a team August 20, 2024 20:14
Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality works well, nice work!

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and works well locally, nice work!

@jriddle-linode jriddle-linode merged commit c0a860c into linode:dev Sep 3, 2024
4 of 5 checks passed
@jriddle-linode jriddle-linode deleted the new/supress_warning branch September 3, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Config based "--suppress-warnings" or, more specifically, quiet version mismatch warning
4 participants