Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added enum for exit codes #622

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Added enum for exit codes #622

merged 4 commits into from
Jun 21, 2024

Conversation

ErikZilber
Copy link
Contributor

📝 Description

Added enum for exit codes and modified existing sys.exit calls to use it

@ErikZilber ErikZilber requested a review from a team as a code owner June 20, 2024 17:33
@ErikZilber ErikZilber requested review from lgarber-akamai and yec-akamai and removed request for a team June 20, 2024 17:33
@ErikZilber ErikZilber force-pushed the TPT2719_add_exit_code_enum branch 2 times, most recently from 5cc41cd to 113aeaf Compare June 20, 2024 18:33
lgarber-akamai
lgarber-akamai approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after linting is fixed, nice work! During the next release we should communicate that some exit codes may have changed since the previous release.

yec-akamai
yec-akamai approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yec-akamai yec-akamai merged commit 0d4f59c into linode:dev Jun 21, 2024
6 checks passed
@ykim-1 ykim-1 mentioned this pull request Aug 8, 2024
Merged
@zliang-akamai zliang-akamai added the improvement for improvements in existing functionality in the changelog. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes

@yec-akamai yec-akamai yec-akamai approved these changes

Assignees
No one assigned
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ErikZilber @lgarber-akamai @yec-akamai @zliang-akamai