Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Clusters Choice in OBJ Plugin Config to be Text Input #618

Conversation

zliang-akamai
Copy link
Member

@zliang-akamai zliang-akamai commented Jun 6, 2024

📝 Description

The upcoming MultiCluster OBJ service will introduce multiple clusters per region, and clusters list API will be deprecated.

Removing clusters list when doing linode obj configure and change it to a text input.

✔️ How to Test

Automated Testing

pytest tests/integration/obj
make testunit

Manual Testing

linode obj configure

Then type any cluster you want:

(venv) myusername@mylaptop linode-cli % linode obj configure

Configure a default Cluster for operations. (Optional): us-mia-1

Or leave it blank:

(venv) myusername@mylaptop linode-cli % linode obj configure

Configure a default Cluster for operations. (Optional):

And then try any obj plugin commands, for examples:

linode obj la
linode obj la --cluster us-east-1

@zliang-akamai zliang-akamai requested a review from a team as a code owner June 6, 2024 06:57
@zliang-akamai zliang-akamai requested review from lgarber-akamai and ykim-1 and removed request for a team June 6, 2024 06:57
@zliang-akamai zliang-akamai changed the base branch from dev to proj/multicluster-obj June 6, 2024 17:25
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and everything works well, nice work!

Co-authored-by: Lena Garber <114949949+lgarber-akamai@users.noreply.github.com>
Copy link
Contributor

@ykim-1 ykim-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests pass locally

@zliang-akamai zliang-akamai merged commit 618b04a into linode:proj/multicluster-obj Jun 11, 2024
5 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/remove-clusters-choice-from-obj-config branch June 11, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants