Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --all-rows Flag #455

Merged
merged 7 commits into from
May 23, 2023
Merged

Conversation

zliang-akamai
Copy link
Member

📝 Description

Provide a option for user to output all results without pagination.

Should we add some integration/unit tests for this? Will be working on that if necessary.

✔️ How to Test

Create 1000 stackscripts in your account then run linode --all-rows stackscripts ls --is_public false

@zliang-akamai zliang-akamai requested a review from a team May 9, 2023 22:06
linodecli/cli.py Outdated Show resolved Hide resolved
Signed-off-by: Zhiwei Liang <zliang@akamai.com>
Signed-off-by: Zhiwei Liang <zliang@akamai.com>
Signed-off-by: Zhiwei Liang <zliang@akamai.com>
Signed-off-by: Zhiwei Liang <zliang@akamai.com>
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected on my end. One small change and we should be good to go 👍

linodecli/__init__.py Outdated Show resolved Hide resolved
@zliang-akamai zliang-akamai requested review from lgarber-akamai and a team May 19, 2023 01:59
Copy link
Contributor

@ezilber-akamai-zz ezilber-akamai-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work!

@zliang-akamai zliang-akamai merged commit 4cdacf8 into linode:dev May 23, 2023
@zliang-akamai zliang-akamai deleted the zhiwei/all-rows branch May 23, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants