Bump @material-ui/icons from 4.9.1 to 4.11.2 in /web/app #6310
Conversation
![dependabot[bot]](https://github.com/avatars/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
Bumps [@material-ui/icons](https://github.com/mui-org/material-ui/tree/HEAD/packages/material-ui-icons) from 4.9.1 to 4.11.2. - [Release notes](https://github.com/mui-org/material-ui/releases) - [Changelog](https://github.com/mui-org/material-ui/blob/v4.11.2/CHANGELOG.md) - [Commits](https://github.com/mui-org/material-ui/commits/v4.11.2/packages/material-ui-icons) --- updated-dependencies: - dependency-name: "@material-ui/icons" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Dennis Adjei-Baah <dennis@buoyant.io>
dadjeibaah
force-pushed
the
dependabot/npm_and_yarn/web/app/material-ui/icons-4.11.2
branch
from
81d7800
to
2c32239
Compare
There was a problem hiding this comment.
Thanks for fixing this up, @dadjeibaah!
A few questions for my own information:
- Can you briefly explain what the relevant change in the underlying library was? icons can no longer be looked up by name?
- I notice the test switches from testing that the result is defined instead of testing that it has length 1. Can you explain? Could the result have a different length and would that be okay?
- There are a bunch of whitespace changes in this diff. Do they make the formatting in this file more consistent with the rest of the repo?
|
@adleong, these are all good questions.
It seems they were not wrapped by a React functional component. After this update, this is what an icon looks like now My guess is that the current test doesn't work quite well with React functional components like
Ah it looks like this change is unnecessary. The tests still work even if we test to make sure the component has a length of 1 as long as we change the way we lookup the component. I'll revert this change.
I can back those out. I'm not entirely clear on what are formatting is for the frontend so I'm not sure if this makes things more consistent or the opposite. I think we probably need to revisit frontend formatting and go through to make sure things are consistent. In the interest of keeping this diff concise, I'll remove these whitespace changes. |
Signed-off-by: Dennis Adjei-Baah <dennis@buoyant.io>
kleimkuhler
deleted the
dependabot/npm_and_yarn/web/app/material-ui/icons-4.11.2
branch
Bumps @material-ui/icons from 4.9.1 to 4.11.2.
Release notes
Sourced from
@material-ui/icons's releases.... (truncated)
Changelog
Sourced from
@material-ui/icons's changelog.... (truncated)
Commits
174b64fv4.11.2328cdd4[core] Support React 17 (#23697)594cfe5[core] Don't ship type tests (#21300)edd2eb5[test] Replace all assert with expect (#20853)72ac760[test] Migrate from assert to expect (#20799)8ea2df8[core] Remove createSvgIcon duplication (#20308)1ca755aBump fs-extra from 8.1.0 to 9.0.0 (#20225)27471b4Bump prettier to 2.0.0 (#20211)4fba0da[core] Migrate to import * as React from 'react' (#19802)47ed4db[docs] Switch to cross-fetch (#19644)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)